Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: honor SP=BLANK if provided on CLI answerfile
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: honor SP=BLANK if provided on CLI answerfile
......................................................................
storage: honor SP=BLANK if provided on CLI answerfile
When hosted-engine-setup deploys an additional host
it reads back the SP UUID from disk; this could be BLANK
(just a after the setup of the first host) or a valid value
if the engine already auto-imported the hosted-engine
storage domain.
Deploying additional host, hosted-engine-setup parses the
answerfile from the first host which contains SP=BLANK.
When the user runs hosted-engine-setup interactively
it parses the first host-answerfile after checking the
storage so hosted-engine-setup will always continue
with SP=BLANK.
Instead, if the user wants to run it unattended, he can
append an answerfile on CLI. Also in that case we have to
honor SP=BLANK if present (if not it's just a random value).
Raising if prepareImage fails since continuing will just
hide the real issue.
Change-Id: I56d2a671db4f288bcb72218a88cb071e241ff781
Bug-Url: https://bugzilla.redhat.com/1311317
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 32 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53976
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56d2a671db4f288bcb72218a88cb071e241ff781
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>