Change in ovirt-engine[master]: webadmin: Remove vNIC items changed listener before flush
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Remove vNIC items changed listener before flush
......................................................................
webadmin: Remove vNIC items changed listener before flush
Upon flushing the AddRemoveRowWidget, it sets the backing ListModel's
items according to the entries in the widget. However, in the add/edit
VM dialog, since it is listening on the items changed event, this
re-initializes the widget just before it closes, thus adding a new
vNIC row. This patch moves the listening logic into
ProfilesInstanceTypeEditor and removes the listener prior to flushing
the widget, in order to avoid that flicker.
Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22
Bug-Url: https://bugzilla.redhat.com/1020755
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
2 files changed, 38 insertions(+), 17 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server