Change in ovirt-engine[master]: core: decrement pending vm on 'run in paused mode'
Arik Hadas has submitted this change and it was merged.
Change subject: core: decrement pending vm on 'run in paused mode'
......................................................................
core: decrement pending vm on 'run in paused mode'
In a flow where VM is started in paused state neither of
runningSucceeded nor runningFailed methods in RunVmCommand are called.
The command is kept in the collection of async commands until the VM
will be resumed.
On resume, the reportCompleted method of the original RunVmCommand will
be called and it will be removed from the async command collection.
Thus, the pending resources are not cleared in this flow.
The solution is to decrease the pending resources in the reportCompleted
method if they were not decreased before.
Change-Id: Icc931118a848c1c7507c407d955537761dd1a742
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/35636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc931118a848c1c7507c407d955537761dd1a742
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server