Change in ovirt-engine-sdk[sdk_4.0]: Fix tag names of action parameters
Ondra Machacek has submitted this change and it was merged.
Change subject: Fix tag names of action parameters
......................................................................
Fix tag names of action parameters
Currently when the SDK generates the XML document to invoke an action
method it assumes that the names of the elements inside the 'action'
match the names of the types of the parameters. This isn't correct, they
should match the names of the parameters, not the names of the types.
For example, the 'Host.iscsi_discover' action method has a parameter of
type 'IscsiDetails' and name 'iscsi', so the tag should be
'iscsi', not
'iscsi_details'. To solve this issue this patch chages the SDK so that
the implementation of action methods create an instance of the 'Action'
type, and render it uusing the 'ActionWriter' class, which knows how to
write it correctly.
Change-Id: Icc05fc5791d6d8ecd2e6c22a6c1aaab96a843b98
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 549d654c91f468adda70640301dd1372e0ce9eab)
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
1 file changed, 11 insertions(+), 52 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63191
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc05fc5791d6d8ecd2e6c22a6c1aaab96a843b98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>