Change in ovirt-engine[ovirt-engine-3.4]: frontend: Fix SPICE-ActiveX upgrade issues
Oved Ourfali has submitted this change and it was merged.
Change subject: frontend: Fix SPICE-ActiveX upgrade issues
......................................................................
frontend: Fix SPICE-ActiveX upgrade issues
This patch basically reverts previous IE 11 workaround:
Syntax error (missing '+' to concatenate strings) in SpicePluginImpl
caused silent fail of activex plugin in IE. This patch addresses this.
This patch also removes IE11 workaround from SpicePluginImpl
(i.e. dummy <PARAM NAME="SecurePort" VALUE="0">). Current SPICE
ActiveX
plugin already works on IE 11 without this workaround (moreover - it
crashes with it!).
Change-Id: I884eafed9985991f5f810378792fb45e00837a5e
Bug-Url: https://bugzilla.redhat.com/1147609
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/33516
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I884eafed9985991f5f810378792fb45e00837a5e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server