4:38 a.m.
Liron Aravot has submitted this change and it was merged.
Change subject: core: replacing fenceSpmStorage with logic within engine
......................................................................
core: replacing fenceSpmStorage with logic within engine
Currently when the SPM is in different statuses the user can manually
confirm that the host has been rebooted in order to attempt to start the
spm on a different host.
That confirmation propogates to the execution of FenceVdsManuallyCommand
that may execute the fenceSpmStorage verb on vdsm through some host.
The fenceSpmStorage verb edits the pool metadata to indicate that
currently there's no host which is the SPM. Later on when the engine
will enter the start spm flow, it will execute the getSpmStatus which
should return that there's no spm and then the engine will attempt to
start the spm on some host within the data center.
On storage pools that use the StoragePoolDiskBackend this flow works, but
when using the new MemoryBackend the spm status result is being returned
from the cluster lock, the data there isn't editable at the moment so on
that case, the spm won't be able to start on other host (as the returned
result would indicate that there's a spm).
On this patch when a user confirm that the spm has been rebooted, we'll
save that in the memory, when the spm selection process will attempt to
select a new spm in case that the reported spm was confirmed to be
fenced by the user - we'll proceed with starting the spm on another
host.
Change-Id: I2e489cd4ff1f8e8686c89d8ceab72c3af3653a56
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092752
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResetIrsVDSCommandParameters.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResetIrsVDSCommand.java
4 files changed, 48 insertions(+), 66 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30539
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e489cd4ff1f8e8686c89d8ceab72c3af3653a56
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server