Change in ovirt-engine[master]: core: error message when deactivating SD with active VMs (#8...
Daniel Erez has submitted this change and it was merged.
Change subject: core: error message when deactivating SD with active VMs (#843407)
......................................................................
core: error message when deactivating SD with active VMs (#843407)
https://bugzilla.redhat.com/843407
canDoAction() of DeactivateStorageDomainCommand runs a stored procedure
to find VMs whose status should prevent deactivation. This patch
renames the SP and associated DAO methods to reflect what it is really
searching for (non-"Down" VMs), as well as changes the error message to
accurately reflect the cause of the failure.
Change-Id: I3ce9ce378ffeed980af508e6556f9d844a3e07bd
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/dbscripts/vms_sp.sql
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 17 insertions(+), 17 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7997
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ce9ce378ffeed980af508e6556f9d844a3e07bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>