Change in ovirt-engine[master]: core: LSM - rollback on non-running VM
Daniel Erez has submitted this change and it was merged.
Change subject: core: LSM - rollback on non-running VM
......................................................................
core: LSM - rollback on non-running VM
LiveMigrateDiskCommand:
Initiating rollback if the VM stops during migration.
On each step of the migration process a new command
is created (in order to execute the next task),
if the VM is no longer running the previous tasks
should be reverted/cleared.
LiveSnapshotTaskHandler:
On compensation, image's status should be reverted to OK.
Updating status using DestinationImageId since ImageId might
be obsolete - depending on which step the failure occurred
(when taking a snapshot, a new active image is generated).
CreateImagePlaceholderTaskHandler:
Rollback should be DeleteImage.
VmReplicateDiskStartTaskHandler:
No rollback for task.
Change-Id: I7aafc5cd63f961470124c984afb2e7a9d74a0de2
Bug-Url: https://bugzilla.redhat.com/872316
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java
4 files changed, 35 insertions(+), 21 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8998
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7aafc5cd63f961470124c984afb2e7a9d74a0de2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>