Change in ovirt-engine[master]: engine: forbid single (vm mem) > (host mem)
Roy Golan has submitted this change and it was merged.
Change subject: engine: forbid single (vm mem) > (host mem)
......................................................................
engine: forbid single (vm mem) > (host mem)
Forbid running single vm with mem > host physical memory.
Yet we allow running few vms with total mem > host physical memory. (relying on
balloning).
This might be unwise yet can occour after migration or/and host downsizing.
Whenever the: (vm mem) > (host mem) the host will start swaping and performance
degrage.
If it possible to think of scenrios vm allocated large mem and not using it, and cannot
downsize vm mem.
Fix swap and refactor reused messages.
If fail run vm due to insufficent mem. Report the available mem.
Added unit test to SlaValidatorTest
Change-Id: Ia5f5280c43820732a36a235024ec5c887c9fcb98
Bug-Url: https://bugzilla.redhat.com/1180071
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SlaValidatorTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 99 insertions(+), 13 deletions(-)
Approvals:
Dudi Maroshi: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5f5280c43820732a36a235024ec5c887c9fcb98
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server