Change in ovirt-engine[master]: webadmin: Null pointer dereferences in model classes
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Null pointer dereferences in model classes
......................................................................
webadmin: Null pointer dereferences in model classes
Added null check when calling Configurator#getSyntaxChecker
in WebAdmin context (CommonModel and SearchSuggestModel) to
fix FindBugs "Null pointer dereferences" warning.
In practice, WebAdminConfigurator#getSyntaxChecker (bound in
WebAdmin's UiCommonModule) always returns non-null reference
so this is just to eliminate the FindBugs warning.
Change-Id: I6b352518d0a306c69e7fcb5d778b76f38e0c848e
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
2 files changed, 15 insertions(+), 8 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/41405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b352518d0a306c69e7fcb5d778b76f38e0c848e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org