Change in jenkins[master]: Separate jenkins diffs folders
From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80161
)
Change subject: Separate jenkins diffs folders
......................................................................
Separate jenkins diffs folders
This patch fixes two main issues:
1) We do not want to have git changes in the original
workspace. For that we will create a temporary
folder for running the JJB in order to create the
old_xmls
2) Jenkins check-patch diffed the current patch with
the current master which was wrong. We actually want
to diff the current patch with the master it was on.
Some additional changes:
1) Removed execution of check_publishers_not_deleted.py
from check-patch.sh and added it to jenkins_check_yaml.sh
2) Changed the code of jenkins_check_yaml.sh to be a bit
more modular. Without global parameters and with functions
Change-Id: Idb16bb01e07f952a00ed88ea2ea6bdc4b835f73d
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M automation/check-patch.sh
M automation/check_publishers_not_deleted.py
M automation/jenkins_check_yaml.sh
3 files changed, 89 insertions(+), 68 deletions(-)
Approvals:
Barak Korren: Looks good to me, approved; Ready for merge
Gil Shinar: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb16bb01e07f952a00ed88ea2ea6bdc4b835f73d
Gerrit-PatchSet: 9
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Staging Jenkins Server