Change in ovirt-engine[master]: core: Changed illegal error msg to locked(#840304)
Michael Kublin has submitted this change and it was merged.
Change subject: core: Changed illegal error msg to locked(#840304)
......................................................................
core: Changed illegal error msg to locked(#840304)
Replaced VM in illegal state error message to locked VM in
ImagesHandler.PerformImagesChecks() when the VM is indeed locked.
The specific flow of actions to introduce the wrong message was
Trying to export a VM while committing a preview.
This yielded a statement that the VM's state is illegal while it should
only say that it's locked.
This should correct other flow of events as well.
ACTION_TYPE_FAILED_VM_IS_LOCKED message is added and used in the appropriate
place
- ImagesHandler.PerformImagesChecks() - if the VM is locked and disks
are not.
Change-Id: I2edb7b8c946589f3bbad251d533704fe856bc175
Bug-Url: https://bugzilla.redhat.com/840304
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 13 insertions(+), 4 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2edb7b8c946589f3bbad251d533704fe856bc175
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>