Change in ovirt-engine[master]: core: refactor; encapsulation
Alona Kaplan has submitted this change and it was merged.
Change subject: core: refactor; encapsulation
......................................................................
core: refactor; encapsulation
• Map<Guid, Whatever> is only mapping Guid to Whatever. It does not
guarantee, that Guid is ID of Whatever. This should be somehow
strongly enforced; it's not safe passing mappings around forcing
callee to trust caller, that he did mapping right. Touched files was
not interrested in created Maps itself ~ true usecase was: get network
for iface and get network for attachment.
Change-Id: Ic42fb58302a66995f366227e43950d2722c77b33
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java
3 files changed, 31 insertions(+), 30 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36143
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic42fb58302a66995f366227e43950d2722c77b33
Gerrit-PatchSet: 58
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org