Change in ovirt-engine-cli[master]: cli: Add support for --type-name options
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Add support for --type-name options
......................................................................
cli: Add support for --type-name options
Currently when a parent object needs to be specified in a command the
only alternative is to use the "--type-identifier" option. This option
will locate the parent object that matches the given identifier if it is
an UUID, or the name otherwise. The problem is that some parent objects
have identifiers that aren't UUIDs, so this won't be able to locate
them. To avoid this issue this patch introduces new "--type-name"
options that can be used in the same places that the "--type-identifier"
options are used. When using the existing "--type-identifier" option the
parent object will be located only by id, and when using the
"--type-name" option it will be located only by name, thus elimiating
any potential ambiguity.
Change-Id: I438e0d5e3c29302fda63e0f0ab01e87a6841e10e
Bug-Url: https://bugzilla.redhat.com/1177367
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/messages.py
M src/ovirtcli/command/action.py
M src/ovirtcli/command/add.py
M src/ovirtcli/command/command.py
M src/ovirtcli/command/remove.py
M src/ovirtcli/command/show.py
M src/ovirtcli/command/update.py
M src/ovirtcli/utils/autocompletionhelper.py
8 files changed, 88 insertions(+), 74 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I438e0d5e3c29302fda63e0f0ab01e87a6841e10e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org