Change in ovirt-engine[master]: core: Add IConfigUtilsInterface#refresh()
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Add IConfigUtilsInterface#refresh()
......................................................................
core: Add IConfigUtilsInterface#refresh()
Move the refreshing logic to the interface so it can be called
generically, without having to depend on the DBConfigUtils specific
implementation.
This is required in order to change
ConfigUtilsBase#getValue(VdcOption) to an instance method, which allows
it to call the polymorphic getValue(ConfigValues, String), thus solving
the regression introduced in 32a5e8, where value dependent config
values retrieved ONLY the defaults even if a value was present in the
database.
Change-Id: I0b0358ae542fdf1d6b9265ce7cdca8adcaf91d83
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ReloadConfigurationsCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/IConfigUtilsInterface.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ConfigUtilsBase.java
M
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockConfigRule.java
6 files changed, 32 insertions(+), 37 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65848
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b0358ae542fdf1d6b9265ce7cdca8adcaf91d83
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>