Change in ovirt-engine[master]: core: Make MoveOrCopyTemplateCommand abstract
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Make MoveOrCopyTemplateCommand abstract
......................................................................
core: Make MoveOrCopyTemplateCommand abstract
As a step to remove this unused (and useless) command, this patch
makes it abstract and removes the methods that are overriden by all the
classes that extend it.
The test was also removed (as this class can no longer be instantiated),
as well as audit log constants that are no longer used anywhere in the
codebase one the respective methods this patch cleans up were removed.
Change-Id: Id6267cb8f13e0f395b8737862dbe86768f4941ab
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java
D
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommandTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
A packaging/dbscripts/upgrade/04_00_0400_delete_copy_template_auditlog.sql
5 files changed, 10 insertions(+), 259 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6267cb8f13e0f395b8737862dbe86768f4941ab
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>