Change in ovirt-engine[ovirt-engine-3.6]: core: Remove useless map in "VmManagementCommandBase"
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove useless map in "VmManagementCommandBase"
......................................................................
core: Remove useless map in "VmManagementCommandBase"
This is needed in order to avoid the following findbugs warning:
Useless object created
Our analysis shows that this object is useless. It's created and
modified, but its value never go outside of the method or produce any
side-effect. Either there is a mistake and object was intended to be
used or it can be removed.
This analysis rarely produces false-positives. Common false-positive
cases include:
- This object used to implicitly throw some obscure exception.
- This object used as a stub to generalize the code.
- This object used to hold strong references to weak/soft-referenced
objects.
Bug kind and pattern: UC - UC_USELESS_OBJECT
Bug-Url: https://bugzilla.redhat.com/1256657
Change-Id: I6e773e3a1ae8d901d9d6e3e9a09c3942447c923f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
1 file changed, 18 insertions(+), 35 deletions(-)
Approvals:
Roman Mohr: Verified
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47844
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e773e3a1ae8d901d9d6e3e9a09c3942447c923f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org