Change in ovirt-engine[master]: webadmin: fix UI exceptions in volumes tab
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fix UI exceptions in volumes tab
......................................................................
webadmin: fix UI exceptions in volumes tab
This patch fixes the UI exceptions in following places
1. Exceptions are flooded in the UI, with user hower
over the the empty Activities column in Gluster Volumes
tab and Bricks Subtab.
There is a NPE in VolumeActivityCompositeCell.
getContainerElement() method. Fixed this issue by showing
the composite cell always. When there is not activity in
the volume then we will add a table with empty row.
2. There is an exception in UI, when there is no suitable
cluster for gep rep slave. We should not try to set the
selection when the list itself is empty.
Change-Id: If1fcfb584dd250ec7550df98eeb4dfe7c442fc5a
Bug-Url: https://bugzilla.redhat.com/1303878
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivityCompositeCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivitySeperatorCell.java
5 files changed, 24 insertions(+), 29 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
anmolbabu: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/54574
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1fcfb584dd250ec7550df98eeb4dfe7c442fc5a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>