Change in ovirt-engine[master]: core: fix inconsistency with empty cd-rom value
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix inconsistency with empty cd-rom value
......................................................................
core: fix inconsistency with empty cd-rom value
By default, the CD-ROM attached to the VM is NULL.
VDSM also reports NULL value in case no CD-ROM is attached.
Recently RunVmCommand was changed to persist the CD-ROM
that is attached to a VM as well, however, it is then set
to an empty string if no CD-ROM is attached. Therefore, the
monitoring gets empty string from the DB and NULL value
from VDSM and decides to update VM dynamic data because of
this change. But later on, the NULL value from VDSM is
ignored and thus, this flow will happen on every monitoring
cycle, leading to many redundant updates of VM dynamic daa.
Change-Id: I5e2afff36f3ee02b57a43760ab88f0a9c3176f37
Bug-Url: https://bugzilla.redhat.com/1340722
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
A packaging/dbscripts/upgrade/04_00_0740_empty_current_cd_to_null.sql
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58304
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e2afff36f3ee02b57a43760ab88f0a9c3176f37
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>