Change in ovirt-engine[master]: webadmin: improve Discard After Delete UX
From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: improve Discard After Delete UX
......................................................................
webadmin: improve Discard After Delete UX
When creating/editing a block storage domain, the user is not warned
when the value of Discard After Delete (DAD) is illegal (the storage
domain contains at least one lun that doesn't support discard).
Since the error comes from the backend, the user doesn't get the chance
to fix the configuration before the popup is closed.
This patch adds UI verifications for DAD to gain a better UX:
1. When enabling DAD, or when selecting a lun while DAD is already
enabled - if the configuration is illegal then a warning message is
shown above the view.
2. When clicking on "ok", DAD is validated so that if the configuration
is illegal then the DAD checkbox is highlighted and the operation is
blocked in the UI level.
Change-Id: I3024fb3ba46ed568cfa0d9d84c15c416da7e335f
Bug-Url: https://bugzilla.redhat.com/1436160
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
4 files changed, 68 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/73851
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3024fb3ba46ed568cfa0d9d84c15c416da7e335f
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>