Change in ovirt-engine-cli[master]: cli: Don't depend on optparse
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Don't depend on optparse
......................................................................
cli: Don't depend on optparse
Currently the dependency on the "optparse" module is deep in the
implementation of the CLI. This causes issues, like unexpected exit from
the "connect" command when passing incorrect options. To avoid these
issues this patch isolates the use of the "optparse" module to the main
program, so that the rest of the code will just receive the already
parsed options.
Change-Id: If3d71de72f929125229e8c8d0e86df5239fad07d
Bug-Url: https://bugzilla.redhat.com/1135550
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/context.py
M src/ovirtcli/infrastructure/context.py
M src/ovirtcli/infrastructure/settings.py
M src/ovirtcli/main.py
M src/ovirtcli/shell/actioncmdshell.py
M src/ovirtcli/shell/addcmdshell.py
M src/ovirtcli/shell/capabilitiescmdshell.py
M src/ovirtcli/shell/clearcmdshell.py
M src/ovirtcli/shell/cmdshell.py
M src/ovirtcli/shell/connectcmdshell.py
M src/ovirtcli/shell/consolecmdshell.py
M src/ovirtcli/shell/disconnectcmdshell.py
M src/ovirtcli/shell/engineshell.py
M src/ovirtcli/shell/filecmdshell.py
M src/ovirtcli/shell/historycmdshell.py
M src/ovirtcli/shell/infocmdshell.py
M src/ovirtcli/shell/listcmdshell.py
M src/ovirtcli/shell/pingcmdshell.py
M src/ovirtcli/shell/removecmdshell.py
M src/ovirtcli/shell/showcmdshell.py
M src/ovirtcli/shell/statuscmdshell.py
M src/ovirtcli/shell/summarycmdshell.py
M src/ovirtcli/shell/updatecmdshell.py
23 files changed, 99 insertions(+), 111 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3d71de72f929125229e8c8d0e86df5239fad07d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org