Change in ovirt-engine[master]: engine : Support logging of commands parameters
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Support logging of commands parameters
......................................................................
engine : Support logging of commands parameters
When debug mode is enabled the command parameters
excluding the ones in the VdcParametersBase are
logged when the command is executed.
Fields that need to excluded from the debug log
like passwords can be marked with the new Annotation
ShouldNotBeLogged and they will be skipped from the log
Change-Id: Idfd9423e92f9f9c9a51eca24b20157cc32681018
Bug-Url: https://bugzilla.redhat.com/1095240
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeUserPasswordParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LoginUserParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ShouldNotBeLogged.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SysPrepParams.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReflectionUtils.java
8 files changed, 93 insertions(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfd9423e92f9f9c9a51eca24b20157cc32681018
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server