Change in ovirt-engine[master]: core: extract vm numa updates from resource manager
Arik Hadas has submitted this change and it was merged.
Change subject: core: extract vm numa updates from resource manager
......................................................................
core: extract vm numa updates from resource manager
It is wrong to clear VM numa nodes in DestroyVmVdsCommand because at
that point we cannot be sure that the VM was really destroyed. We
should have waited for the monitoring to detect that the VM is indeed
down and only then clear the VM numa nodes.
But that is the only place that currently rely on internalSetVmStatus
in ResourceManager to clear VM numa nodes. We want this method to
receive only VmDynamic eventually, so as part of this patch I just
extract the updates of VM numa nodes from it to the destroy command.
Change-Id: I504829db92044f4c0a1df41b9f14e2304ce6608f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
2 files changed, 1 insertion(+), 5 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60928
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I504829db92044f4c0a1df41b9f14e2304ce6608f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>