Change in ovirt-engine[master]: frontend: Prevent selecting web based console clients in IE
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Prevent selecting web based console clients in IE
......................................................................
frontend: Prevent selecting web based console clients in IE
Prevent selecting noVNC/SPICE-HTML5 in 'Console Options' view when viewing
engine via Internet Explorer.
IE doesn't support inter-frame communication html5 standard called 'post
message', which we use for passing data from the engine to noVNC/SPICE-HTML5
client.
Moreover, this patch adds a check for compatibility SPICE-HTML5 to
SpiceConsoleModel which prevents selecting this client from selecting when not
supported.
Change-Id: I8d3845a4a34bbbb703e5b9e04e7ee194071b51ca
Bug-Url: https://bugzilla.redhat.com/1080013
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
6 files changed, 30 insertions(+), 18 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/34836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d3845a4a34bbbb703e5b9e04e7ee194071b51ca
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server