Change in ovirt-engine[master]: core: fix memory state removal on import vm rollback
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix memory state removal on import vm rollback
......................................................................
core: fix memory state removal on import vm rollback
In case import vm operation fails, we rollback the changes and in
particular we remove the memory states of the imported vm from the
data domain.
This patch fix a problem that the memory state images were not removed
by modify the condition that determines if the memory state should be
removed in that case.
The memory states removal was also improved:
if there are no memory states in the snapshots of the imported vm,
the creation of MemoryImageRemover will be skipped.
Change-Id: I98b9908c5332ed66494cc56d826f95314f4f0fee
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
3 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98b9908c5332ed66494cc56d826f95314f4f0fee
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server