Change in ovirt-engine[master]: frontend: SPICE port is sent as 65535 to spice_html5
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: SPICE port is sent as 65535 to spice_html5
......................................................................
frontend: SPICE port is sent as 65535 to spice_html5
Regression introduced by ece8952062f708245ddc527987eeb9c00d3b3fc4 where the
check securePort == -1 ? false : true has been replaced by
consoleOptions.getSecurePort().
The problem is that the securePort has been used instead of getSecurePort
intentionally since the getter returns "securePort & 0xffff" not to send
negative value to the spice client.
Fixed by providing also a getter to get the raw walue
Change-Id: I65a8393a465ebee988f03ec56efa0319626fa0e1
Bug-Url: https://bugzilla.redhat.com/1210379
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Looks good to me, but someone else must approve
Martin Betak: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40578
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65a8393a465ebee988f03ec56efa0319626fa0e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org