Change in ovirt-engine[ovirt-engine-4.0]: aaa: Consolidate SSO session validation requests
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Consolidate SSO session validation requests
......................................................................
aaa: Consolidate SSO session validation requests
Engine makes multiple queries to SSO
to validate each exisitng session. This
could cause performance issue when there
are thousands of sessions. Combining all
requests into one request to fetch all
the statuses in one request can resolve
the performance issue.
When SSO clears an engine session associated
with a token by invoking TerminateSessionsForToken
SSO_ACCESS_TOKEN_PARAMETER value in the
map is null. This can lead to problems when
equality is checked with the contents of
the map for the token.
Change-Id: Ie63dd4e85ac4e4b25cd2884d07d84483dc8add17
Bug-Url: https://bugzilla.redhat.com/1379805
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java
M
backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java
M
backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java
5 files changed, 58 insertions(+), 25 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65095
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie63dd4e85ac4e4b25cd2884d07d84483dc8add17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>