Change in ovirt-engine[master]: core: prevent NPE when exporting networkless NIC
From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79965
)
Change subject: core: prevent NPE when exporting networkless NIC
......................................................................
core: prevent NPE when exporting networkless NIC
As part of the recent changes aim to align the OVF generation in oVirt
with the standard specification of OVF, we changed the OVF generator
to write the actual network names in the NetworkSection rather than a
single network named "Network 1". What we missed, however, is that a
NIC may not be associated with any network. This leads to an NPE in
the OVF generation process. Adding a null-check to prevent that.
Change-Id: I7d120cfaf75f5c0036b3df0062fed2600945e4da
Bug-Url: https://bugzilla.redhat.com/1476191
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/79965
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d120cfaf75f5c0036b3df0062fed2600945e4da
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>