Change in ovirt-engine[master]: core: Support undoing diskless previews (#848298)
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Support undoing diskless previews (#848298)
......................................................................
core: Support undoing diskless previews (#848298)
https://bugzilla.redhat.com/848298
This patch fixes the broken "Undo Preview" for a snapshot that contains
no disks.
It removes some restrictions in the canDoAction and explicitly invokes
endActionOnVmConfiguration() if there are no tasks (which prevents it
from being invoked in the normal async task flow).
Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
2 files changed, 48 insertions(+), 44 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server