Change in ovirt-engine[ovirt-engine-3.5]: core: Source VM is deleted after failed cloning attempt
Tal Nisan has submitted this change and it was merged.
Change subject: core: Source VM is deleted after failed cloning attempt
......................................................................
core: Source VM is deleted after failed cloning attempt
The root cause was that in the rollback flow the VM id has been inited from the
getParameters().getVmId() which points to the old VM.
Than, in AddVmCommand.removeVmRelatedEntitiesFromDb() the removeVmStatic() used
it to delete the VM - but since it pointed to the old VM it has been deleted.
Fixed by making sure that the VM ID always points to the new VM.
Change-Id: Ia44f6394914f956013c81ffef2dbcbfb120ec301
Bug-Url: https://bugzilla.redhat.com/1236608
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42967
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia44f6394914f956013c81ffef2dbcbfb120ec301
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org