Change in ovirt-engine[master]: webadmin: edit 'instance type' on double click
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: edit 'instance type' on double click
......................................................................
webadmin: edit 'instance type' on double click
The method getEditCommand in a model must return the command that opens
the edit dialog in order to open the edit dialog on double click on one
of its items.
The model for instance-types didn't override this method, thus it
returned null and the edit dialog wasn't opened on double click on
instance type. The solution is to override the getEditCommand method and
delegate to the getEditInstanceTypeCommand method.
Change-Id: Ic15aff5ee200b9e5a9f04a397a6571f362b90c38
Bug-Url: https://bugzilla.redhat.com/1174655
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Shahar Havivi: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/36398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic15aff5ee200b9e5a9f04a397a6571f362b90c38
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server