From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin,userportal: Support multiple dialogs per model
......................................................................
webadmin,userportal: Support multiple dialogs per model
Before this patch, each model can have only two dialog instances
associated & shown at any given time:
1: (generic) dialog instance, bound to 'Window' property
2: (confirm) dialog instance, bound to 'ConfirmWindow' property
After this patch, more (custom) dialog instances are supported by
means of overriding corresponding ModelBoundPopupResolver methods:
* for custom 'Window'-like properties
- getWindowPropertyNames
- getWindowModel
- clearWindowModel
* for custom 'ConfirmWindow'-like properties
- getConfirmWindowPropertyNames
- getConfirmWindowModel
- clearConfirmWindowModel
Change-Id: Ie136f6cdae498da7533017f4d160d3b4858b0c93
Bug-Url:
https://bugzilla.redhat.com/1391466
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java
1 file changed, 63 insertions(+), 28 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Verified
--
To view, visit
https://gerrit.ovirt.org/67521
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie136f6cdae498da7533017f4d160d3b4858b0c93
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>