Change in ovirt-engine[master]: engine: Allow to iterate over remaining ldap servers on Null...
Roy Golan has submitted this change and it was merged.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
......................................................................
engine: Allow to iterate over remaining ldap servers on NullPointerException.
When engine-manage-domain is run to add ldap server, current code finds all
ldap servers in the domain and then finds guid on each. In some cases it
gets NullPointerException because the "uniqueId" is not found. In those cases
we currently go to the default "Exception" and break out of ldap server loop.
In my view, we should log/print the message and continue to serve the loop.
This patch is based on http://gerrit.ovirt.org/#/c/4439/2. Since now we have
support for ITDS, the original patch has been updated.
Change-Id: Iaf89ef5d423cde2e420d6196b38506a23416abb8
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
1 file changed, 23 insertions(+), 14 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf89ef5d423cde2e420d6196b38506a23416abb8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>