Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix empty quota validation in edit disk
......................................................................
core: Fix empty quota validation in edit disk
When a disk with no quota is edited and the quota is not setted by the
user, no quota validation takes place. The operation succeeds.
This error is due to wrong logic in UpdateVmDiskCommand.
Logic was change so that only if quota is non-empty and was not changed
by user, it will not be validated.
Change-Id: I697171e9c47499048d5a735c0f0e5a253b41892a
Bug-Url:
https://bugzilla.redhat.com/895981
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
1 file changed, 23 insertions(+), 17 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/11434
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I697171e9c47499048d5a735c0f0e5a253b41892a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>