Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Cluster sub general tab broken
......................................................................
webadmin: Cluster sub general tab broken
- For certain locales the cluster general sub tab would not
popuplate its values. This was due to an exception being
thrown in the value parser of read only fields. Since these
field are readonly they don't need a parser.
- Added a new EntityModelLabelEditor constructor without a parser
that is meant for readonly fields.
Change-Id: I9c7a911d7a6ecfe79ee006be46e0ef8e627b97e3
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1157380
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelLabelEditor.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java
3 files changed, 21 insertions(+), 24 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/34648
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c7a911d7a6ecfe79ee006be46e0ef8e627b97e3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server