Oved Ourfali has submitted this change and it was merged. Change subject: core: fix commit snapshot flow on active vm commit ...................................................................... core: fix commit snapshot flow on active vm commit * RestoreAllSnapshotsCommand -> getSnapshot method: - COMMIT branch: get IN_PREVIEW snapshot by status. * SnapshotDao: - Added a new getter for fetching snapshots only by status. * snapshot_sp.sql: - Added GetSnapshotByVmIdAndStatus stored procedure. Change-Id: Ib27d225b7bf584f1d0c6e2861e91403ba205f087 Bug-Url: https://bugzilla.redhat.com/1093047 Signed-off-by: Daniel Erez <derez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java M packaging/dbscripts/snapshots_sp.sql 6 files changed, 51 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib27d225b7bf584f1d0c6e2861e91403ba205f087 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server