1:46 p.m.
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--xvMtfUX5HHjXEqJwuW5CnHdISAmO6Dw61
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On Tue 11 Mar 2014 10:41:47 AM CET, Ewoud Kohl van Wijngaarden wrote:
I strongly feel the wiki page name should reflect that it is for
infra.=
The current name is very generic and leads to assuptions that
it's for
the entire project. And you know what happens when you assume[1].
Agree, I'll change it, it's not clear is for infra at first sight (it=20
says so in the first lines, but in the title would make it a lot=20
clearer).
Other than that, I agree with you.
[1]: https://xkcd.com/1339/
hehehehe, good one xd
On Tue, Mar 11, 2014 at 04:35:11AM -0400, David Caro Estevez wrote:
> Correct.
>
> It seems that ovirt is targeted also to non-gnu oses (in the future I =
suppose) so portability inside the product is an issue, thus making the s=
trict POSIX standard the appropriate tool. I'm not sure if there's any mi=
lestone set for that, but as I see it, is quite far, as I've been more th=
an one year in the project, and we haven't got out of redhat based distri=
butions, I see really hard to support non-gnu oses but if that's what was=
decided, let's go for it.
>
> But for any script we use to maintain the infrastructure of the projec=
t, from
running a jenkins job, to creating repositories or adding a nagio=
s check, we don't need to limit ourselves with POSIX, so we can benefit f=
rom the whole range of advantages and features bash offers and that gives=
us easy to write and easy to read scripts, making it easier to maintain =
and debug.
>
> ----- Original Message -----
>> From: "Kiril Nesenko" <knesenko(a)redhat.com>
>> To: "Eli Mesika" <emesika(a)redhat.com>
>> Cc: "David Caro" <dcaroest(a)redhat.com>, "infra"
<infra(a)ovirt.org>
>> Sent: Tuesday, March 11, 2014 9:11:28 AM
>> Subject: Re: Infra scripting style guide proposal
>>
>>
>>
>> ----- Original Message -----
>>> From: "Eli Mesika" <emesika(a)redhat.com>
>>> To: "David Caro" <dcaroest(a)redhat.com>
>>> Cc: "infra" <infra(a)ovirt.org>
>>> Sent: Tuesday, March 11, 2014 1:32:40 AM
>>> Subject: Re: Infra scripting style guide proposal
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "David Caro" <dcaroest(a)redhat.com>
>>>> To: "infra" <infra(a)ovirt.org>
>>>> Sent: Monday, March 10, 2014 9:17:13 PM
>>>> Subject: Infra scripting style guide proposal
>>>>
>>>> Hi everyone,
>>>>
>>>> Following the discussion thread and seeing that there's no more inp=
ut
>>>> there,
>>>> I'd
>>>> like to propose this style guide:
>>>>
>>>> http://www.ovirt.org/Bash_style_guide
>>>>
>>>> As standard for our infrastructure scripts and guideline when revie=
wing
>>>> scripts.
>>>>
>>>> All the infra members please review the style guide and answer this=
email
>>>> with
>>>> your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -=
1, add
>>>> also a
>>>> description of the problems you see so we can work on them.
>>>
>>> Hi David
>>> First of all thanks for your efforts in writing that, I am certainly=
for
>>> standards.
>>> However, I feel that we have to decide what kind of scripts we want =
to
>>> write.
>>> Alon (Bar Lev), for example , is for removing what he is calling 'ba=
shisem'
>>> from the infra code, lately we had turned all
dbscripts/dbutils code=
from
>>> bash to POSIX.
>>> So, I think that we should decide first on the direction ('to bash o=
r not
>>> to
>>> bash, this is the question')
>>> Otherwise, we are left with a bunch of scripts, each written differe=
ntly,
>>> and
>>> even if each has its code style guidelines, I believe that it makes =
our
>>> development environment harder to maintain and more buggy
...
>>
>> Hello Eli,
>>
>> Scripts that are going to be shipped with the product should be writt=
en
in
>> POSIX shell and this is correct.
>> But here we are talking about scripts that we (infra team) are going =
to
use
>> to maintain our infrastructure - so there should be no
problem to use=
bash
>> here,
>> since those scripts wont be shipped with the product.
>>
>> - Kiril
>>>
>>>
>>>>
>>>> All the non-infra people, you are welcome to vote also and give inp=
ut,
>>>> but
>>>> your
>>>> single vote will not be decisive.
>>>>
>>>> I'll close the voting next monday if no changes to the Style guide =
are
>>>> proposed.
>>>>
>>>> Thanks!
>>>>
>>>> dcaro +1
>>>>
>>>> --
>>>> David Caro
>>>>
>>>> Red Hat S.L.
>>>> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>>>>
>>>> Email: dcaro(a)redhat.com
>>>> Web: www.redhat.com
>>>> RHT Global #: 82-62605
>>>>
>>>>
>>>> _______________________________________________
>>>> Infra mailing list
>>>> Infra(a)ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>>
>>> _______________________________________________
>>> Infra mailing list
>>> Infra(a)ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>
>>
> _______________________________________________
> Infra mailing list
> Infra(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
--
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--xvMtfUX5HHjXEqJwuW5CnHdISAmO6Dw61
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJTHveeAAoJEEBxx+HSYmnDNosIAJoemDWsjjhRROesYWMaT44W
kaHjTEUYl5Jpd1zUm9g2Elbj1/W6S0LHj6+Cmqb1JCXA3vDGWHXH/qzwvkjq+DQu
vhvCrTP75ylNG++Ad3kc1p/3eFAg/slm/rk4uOAsx88N0z/TKjYl3Ef6kN+BRNfD
MrRn5mIMV6lbPYjCqzJ3DTBc+XdwG03pmGqkh3WgPyJVWz5I+R0r+VeaHybg1Irb
I52qEoTUofDjL3JD+575btLxyu551/VD7t2cgfiQDmK1z9hXG4ExbM5F32GuIxYG
64iQhOrkr3L9EU+ih5fzOuho1wLCvad2nj9xGuIqm934GX3ojwiqbT+t95H4sBg=
=Q+13
-----END PGP SIGNATURE-----
--xvMtfUX5HHjXEqJwuW5CnHdISAmO6Dw61--