Re: Bad setup code in vdsm_master_storage_functional_tests_localfs_gerrit

From: "Eyal Edri" <eedri(a)redhat.com&gt; To: "Nir Soffer" <nsoffer(a)redhat.com&gt; Cc: "infra" <infra(a)ovirt.org&gt;, "Vered Volansky" <vvolansk(a)redhat.com&gt;, "Dan Kenigsberg" <danken(a)redhat.com&gt; Sent: Thursday, June 12, 2014 2:37:33 PM Subject: Re: Bad setup code in vdsm_master_storage_functional_tests_localfs_gerrit we're not maintaining the functional tests code in jenkins, i believe it's vered. vered - do you need any help with refactoring this? eyal. ----- Original Message ----- > From: "Nir Soffer" <nsoffer(a)redhat.com&gt; > To: "infra" <infra(a)ovirt.org&gt;, "Vered Volansky" <vvolansk(a)redhat.com&gt;, "Dan > Kenigsberg" <danken(a)redhat.com&gt; > Sent: Wednesday, June 11, 2014 9:10:40 PM > Subject: Bad setup code in > vdsm_master_storage_functional_tests_localfs_gerrit > > Hi infra, > > I have seen this failure today: > > 16:52:35 Triggered by Gerrit: http://gerrit.ovirt.org/28610 > 16:52:35 Building remotely on dcaro-ovirt-vm02-fc20 (os1 fedora20) in > workspace > /home/jenkins/workspace/vdsm_master_storage_functional_tests_localfs_gerrit > ... > 16:53:00 + sudo sh -c 'echo "" > /var/log/vdsm/vdsm.log' > 16:53:00 sh: /var/log/vdsm/vdsm.log: No such file or directory > 16:53:02 Build step 'Execute shell' marked build as failure > > We need more robust code. Something like: > > vdsm_log="/var/log/vdsm/vdsm.log" > > if [ -f "$vdsm_log" ]; then > sudo sh -c 'echo "" > "$vdsm_log" > fi > > Thanks, > Nir > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra >