----- Original Message -----
From: "Vered Volansky" <vered(a)redhat.com>
To: "Dan Kenigsberg" <danken(a)redhat.com>
Cc: "infra" <infra(a)ovirt.org>
Sent: Tuesday, June 17, 2014 10:40:51 AM
Subject: Re: Bad setup code in vdsm_master_storage_functional_tests_localfs_gerrit
----- Original Message -----
> From: "Dan Kenigsberg" <danken(a)redhat.com>
> To: "Vered Volansky" <vered(a)redhat.com>
> Cc: "infra" <infra(a)ovirt.org>
> Sent: Monday, June 16, 2014 11:29:42 AM
> Subject: Re: Bad setup code in
> vdsm_master_storage_functional_tests_localfs_gerrit
>
> On Sun, Jun 15, 2014 at 04:11:53AM -0400, Vered Volansky wrote:
> > The job with this issue is gone, let me know if it's risen again.
>
> The fragile code is still in
>
http://jenkins.ovirt.org/view/All/job/vdsm_master_storage_functional_test...
> why not make it more robust before /var/log/vdsm disappears and make it
> break again?
because I don't understand the issue. The file is only created if missing.
The directory should be there.
The test failure proves that it may not be there in all cases.
>
> BTW, if /var/log/vdsm/vdsm.log is missing, the discussed line would
> create it owned by root, which would fail the startup of vdsm. Please
> use the vdsm user instead.
Ack.
Why not remove the file - much simpler and cannot fail:
rm -f /var/log/vdsm/vdsm.log
> _______________________________________________
> Infra mailing list
> Infra(a)ovirt.org
>
http://lists.ovirt.org/mailman/listinfo/infra
>
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra