6:58 a.m.
This is a multi-part message in MIME format...
------------=_1516193921-24843-123
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
[
https://ovirt-jira.atlassian.net/browse/OVIRT-1849?page=com.atlassian.jir...
]
Ryan Barry commented on OVIRT-1849:
-----------------------------------
I don't see a good reason not to enable all of them.
At a minimum, set_modified would be great
enable all gerrit hooks for cockpit-ovirt project
-------------------------------------------------
Key: OVIRT-1849
URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1849
Project: oVirt - virtualization made easy
Issue Type: Task
Reporter: eyal edri
Assignee: infra
It looks like the cockpit-ovirt project doesn't have all hooks enabled, current these
are the hooks its using:
/home/gerrit2/review_site/hooks/custom_hooks/update_tracker
/home/gerrit2/review_site/hooks/custom_hooks/comment-added.propagate_review_values
If we want that the hooks will also update bz status and do other verification like
backporing, we need to add more hooks.
[~sbonazzo(a)redhat.com] [~msivak(a)redhat.com] please comment which hooks you'd like to
enable or all of them.
Info on the hooks can be found here
:http://ovirt-infra-docs.readthedocs.io/en/latest/General/Creating_Gerrit_Projects/index.html#enabling-custom-gerrit-hooks
[~amarchuk] fyi
--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100076)
------------=_1516193921-24843-123
Content-Type: text/html; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
<html><body>
<pre>[
https://ovirt-jira.atlassian.net/browse/OVIRT-1849?page=com.atlassian.jir...
]</pre>
<h3>Ryan Barry commented on OVIRT-1849:</h3>
<p>I don't see a good reason not to enable all of them.</p>
<p>At a minimum, set_modified would be great</p>
<blockquote><h3>enable all gerrit hooks for cockpit-ovirt project</h3>
<pre> Key: OVIRT-1849
URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1849
Project: oVirt - virtualization made easy
Issue Type: Task
Reporter: eyal edri
Assignee: infra</pre>
<p>It looks like the cockpit-ovirt project doesn't have all hooks enabled,
current these are the hooks its using:
/home/gerrit2/review_site/hooks/custom_hooks/update_tracker
/home/gerrit2/review_site/hooks/custom_hooks/comment-added.propagate_review_values If we
want that the hooks will also update bz status and do other verification like backporing,
we need to add more hooks. [~sbonazzo(a)redhat.com] [~msivak(a)redhat.com] please comment
which hooks you'd like to enable or all of them. Info on the hooks can be found here
:<a
href="http://ovirt-infra-docs.readthedocs.io/en/latest/General/Creating_Gerrit_Projects/index.html#enabling-custom-gerrit-hooks">http://ovirt-infra-docs.readthedocs.io/en/latest/General/Creating_Gerrit_Projects/index.html#enabling-custom-gerrit-hooks</a>
[~amarchuk] fyi</p></blockquote>
<p>— This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100076)</p>
<img
src="https://u4043402.ct.sendgrid.net/wf/open?upn=i5TMWGV99amJbNxJpS...
alt="" width="1" height="1" border="0"
style="height:1px !important;width:1px !important;border-width:0
!important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0
!important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0
!important;padding-right:0 !important;padding-left:0 !important;"/>
</body></html>
------------=_1516193921-24843-123--
2503
days inactive
2503
days old
0 comments
1 participants
participants (1)
-
Ryan Barry (oVirt JIRA)