Re: [ovirt-devel] Re: planned Jenkins restart

Hi Evgheni, I've noticed that the mails now received from Gerrit are general and not contains the person/mechanism that added the comment. For example, if a person adds a comment or add +1 the mail that receives is - --------------------------------------- View Change <https://gerrit.ovirt.org/c/vdsm/+/112420> 1 comment: - File lib/vdsm/virt/backup.py: <https://gerrit.ovirt.org/c/vdsm/+/112420/2/lib/vdsm/virt/backup.py> - Patch Set #2, Line 216: <https://gerrit.ovirt.org/c/vdsm/+/112420/2/lib/vdsm/virt/backup.py@216> _remove_scratch_disks(vm, backup_id) This duplicate the logic. Maybe: if backup exists: stop backup remove scratch disks Checking for backup exists should handle all cases like vm is undefined, etc. To view, visit change 112420 <https://gerrit.ovirt.org/c/vdsm/+/112420>;. To unsubscribe, or for help writing mail filters, visit settings <https://gerrit.ovirt.org/settings>;. --------------------------------------- In the previous version, the message contains also the person that added that comment. Can we include it in the new version also? Thanks On Tue, 25 Aug 2020 at 02:59, Evgheni Dereveanchin <ederevea(a)redhat.com&gt; wrote: -- Regards, Eyal Shenitzky