Re: Infra scripting style guide proposal
----- Original Message -----
From: "Eli Mesika" <emesika(a)redhat.com>
To: "David Caro" <dcaroest(a)redhat.com>
Cc: "infra" <infra(a)ovirt.org>
Sent: Tuesday, March 11, 2014 1:32:40 AM
Subject: Re: Infra scripting style guide proposal
----- Original Message -----
> From: "David Caro" <dcaroest(a)redhat.com>
> To: "infra" <infra(a)ovirt.org>
> Sent: Monday, March 10, 2014 9:17:13 PM
> Subject: Infra scripting style guide proposal
>
> Hi everyone,
>
> Following the discussion thread and seeing that there's no more input
> there,
> I'd
> like to propose this style guide:
>
> http://www.ovirt.org/Bash_style_guide
>
> As standard for our infrastructure scripts and guideline when reviewing
> scripts.
>
> All the infra members please review the style guide and answer this email
> with
> your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add
> also a
> description of the problems you see so we can work on them.
Hi David
First of all thanks for your efforts in writing that, I am certainly for
standards.
However, I feel that we have to decide what kind of scripts we want to write.
Alon (Bar Lev), for example , is for removing what he is calling 'bashisem'
from the infra code, lately we had turned all dbscripts/dbutils code from
bash to POSIX.
So, I think that we should decide first on the direction ('to bash or not to
bash, this is the question')
Otherwise, we are left with a bunch of scripts, each written differently, and
even if each has its code style guidelines, I believe that it makes our
development environment harder to maintain and more buggy ...
Hello Eli,
Scripts that are going to be shipped with the product should be written in POSIX shell and
this is correct.
But here we are talking about scripts that we (infra team) are going to use to maintain
our infrastructure - so there should be no problem to use bash here,
since those scripts wont be shipped with the product.
- Kiril
>
> All the non-infra people, you are welcome to vote also and give input, but
> your
> single vote will not be decisive.
>
> I'll close the voting next monday if no changes to the Style guide are
> proposed.
>
> Thanks!
>
> dcaro +1
>
> --
> David Caro
>
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>
> Email: dcaro(a)redhat.com
> Web: www.redhat.com
> RHT Global #: 82-62605
>
>
> _______________________________________________
> Infra mailing list
> Infra(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra