Re: Gerrit don't check for "Signed-Off" anymore
On Wed, Dec 28, 2016 at 11:42 AM, Tal Nisan <tnisan(a)redhat.com> wrote:
Last night I've push a serious of patches and forgot to sign off,
up until
not long ago there was a hook that enforces that but it seems like it's not
working anymore and I was able to push the patches without the sign off:
https://gerrit.ovirt.org/#/c/69219/1
Its not a hook, its a definition per project, each project has the
defenition if to enforce signed-off commit:
'Require Signed-off-by in commit message:' - and its on TRUE now for
ovirt-engine, so I'm not sure how its possible that a patch got in, we'll
need to check gerrit logs to see.
Opening a ticket on it.
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
--
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
Attachments:
- attachment.html (text/html — 2.0 KB)