Re: New workflow flag on gerrit jenkins project
--10jrOL3x2xqLmOsH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 04/15, Eyal Edri wrote:
+1. Excellent.
Will it be possible to tell gerrit trigger plugin to run jobs only on pat=
ches
with this flag?
=20
If not, might worth sending a patch to support it. It might reduce dramat=
ically
the amount of jobs running on patches.
Yes, the gerrit plugin does allow filtering by any custom flag (just checke=
d)
=20
Sent from Nine
=20
From: David Caro
Sent: Apr 15, 2015 7:31 PM
To: infra(a)ovirt.org
Subject: New workflow flag on gerrit jenkins project
=20
=20
Hi!
=20
=20
As a test to improve the review process I've enabled a new flag on the je=
nkins
repo, the workflow flag.
=20
This flag has three values:
0 Work in progress (default)
+1 Ready for review
+2 Ready for merge
=20
The idea is to work on a patch without bothering anyone and when ready,
explicitly ask for review in gerrit, that way the reviewer can easily
differenciate between ready and not ready patches. Once the reviews have =
been
done and all, the maintainer can set the +2 and merge the patch (the
idea=
is in
the near future use that flag to trigger zuul, so replacing the
submit bu=
tton).
=20
The new flag shows nicely in the changes screen, making in really easy to=
see
which patches require reviews.
=20
Let's play on that project only for now and see if it works out.
=20
=20
Thanks!!
=20
=20
--=20
David Caro
=20
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
=20
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--10jrOL3x2xqLmOsH
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJVMAwbAAoJEEBxx+HSYmnDAUsH/0jSqfnZuzIXoqWkRMRIPyMt
hs+a0rV1Q8PregEmWF4076ddsuWLNUn3lyaNbtu3YDJqRu5GPenCQsoJzk8dEtSB
+Xlqy64IptCMHn4rk0F6h7XK6WOlP8njsE3SqmfeNKrSbOST+wa+EdE54hABTeqX
AwKP6wh8SXrCxv94SnJBdpwzWVCEiUQsuzn0AlV5kKJdEXIhHRCZJQa+I3ts7uZ9
mcZgu/WDA6+vA37SBFH0/A2n+b0KE1boBSmd3ETBlgHAm/MN2+92g4OPV0DkfPyZ
opWNztDCsQOBIhrMPR1O591nwqAd8GGedP6FI5Ee19D9dy77uvo8Yg+BIJOPr8M=
=diCB
-----END PGP SIGNATURE-----
--10jrOL3x2xqLmOsH--
Attachments:
- attachment.bin (multipart/signed — 2.4 KB)