4:15 a.m.
--s/l3CgOIzMHHjg/5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 02/03 08:55, Eyal Edri wrote:
Do we have a place where all the current logic of the hooks is
described?
I can use it as a base and adjust each one to the new logic we need.
Not really, we have the code, but the task to properly document was never
finished (in part because it's been changing quite often) and the task to
puppetize has been in the backburner (also because gerrit itself is not in
puppet, so it's not straight-forward).
The best you can do is go to gerrit through ssh (port 22) and ls
/home/gerrit2/review_site/git/ovirt-engine.git/hooks.
[root@gerrit ~]# ls /home/gerrit2/review_site/git/ovirt-engine.git/hooks/ch=
ange-abandoned.update_tracker
change-merged.set_MODIFIED
change-merged.update_tracker
comment-added.propagate_review_values
config
patchset-created.bz.0.has_bug_url
patchset-created.bz.1.is_public
patchset-created.bz.2.correct_product
patchset-created.bz.3.correct_target_milestone
patchset-created.bz.98.set_POST
patchset-created.bz.99.review_ok
patchset-created.update_tracker
patchset-created.warn_if_not_merged_to_previous_branch
update_tracker
For the config you have:
## Branches to take into account
BRANCHES=3D('ovirt-engine-3.6' 'ovirt-engine-3.6.0'
'ovirt-engine-3.6.1' 'o=
virt-engine-3.6.2' 'ovirt-engine-3.5' 'ovirt-engine-3.4'
'ovirt-engine-3.3'=
'engine_3.2' 'engine_3.1' 'ovirt-engine-3.5.2'
'ovirt-engine-3.4.0' 'ovirt=
-engine-3.3.4' 'ovirt-engine-3.3.3' 'ovirt-engine-3.3.2'
'ovirt-engine-3.3.=
1')
STABLE_BRANCHES=3D"ovirt-engine-3.6 ovirt-engine-3.6.0 ovirt-engine-3.6.1 o=
virt-engine-3.6.2 ovirt-engine-3.6.3 ovirt-engine-3.5 ovirt-engine-3.4 ovir=
t-engine-3.3 ovirt-engine-3.5.2 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt=
-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1"
CHECK_TARGET_RELEASE=3D("ovirt-engine-3.6|^3\.[6543210].*"
"ovirt-engine-3.=
5|^3\.[543210].*" "ovirt-engine-3.4|^3\.[43210].*"
"ovirt-engine-3.3|^3\.[3=
210].*" "ovirt-engine-3.4.1|^3.4.1$")=20
CHECK_TARGET_MILESTONE=3D('ovirt-engine-3.6.0|^.*3\.6\.0.*$' 'ovirt-engine-=
3.6|^.*3\.6.*' 'ovirt-engine-3.5|^.*3\.5.*'
'ovirt-engine-3.4|^.*3\.4.*' 'o=
virt-engine-3.3|^.*3\.3.*' 'ovirt-engine-3.4.1|^.*3.4.1.*$')=20
PRODUCT=3D"oVirt
=20
On Tue, Feb 2, 2016 at 5:19 PM, David Caro <dcaro(a)redhat.com> wrote:
=20
> On 01/28 16:17, Eyal Edri wrote:
> > David,
> > Is it something manual we need to change per version or we can add
> > something automatic to work on any 3.6.X branch only (exluding the 3.6
> > branch)?
>
> Can you summarize the complete checks that should be done on the hooks
> side? Because it's starting to be a bit of a mess as we are changing
> small things each time without the complete knowledge (for example,
> the target release was being checked before when moving to MODIFIED,
> and that was commented out, and there's a hook to warn if the patch is
> not merged yet on a previous branch, like not being merged on 3.6 if
> it's on 3.6.x)
>
>
>
> >
> > e.
> >
> > On Thu, Jan 28, 2016 at 4:00 PM, Tal Nisan <tnisan(a)redhat.com> wrote:
> >
> > > This was the behavior in 3.6.2, don't know why it changed
> > >
> > > On Thu, Jan 28, 2016 at 3:57 PM, Eyal Edri <eedri(a)redhat.com>
wrote:
> > >
> > >> so maybe we'll stop moving bugs to MODIFIED if they are merged on
> stable
> > >> branch (i.e ovirt-engine-3.6) and only if its merged into a version
> branch
> > >> (i.e ovirt-engine-3.6.3) ?
> > >>
> > >> On Thu, Jan 28, 2016 at 3:52 PM, Tal Nisan <tnisan(a)redhat.com>
wro=
te:
> > >>
> > >>> It makes life easier for everyone when automation moves the bug
to
> > >>> MODIFIED, if the work is not done then the developer can always m=
ove
> it
> > >>> back to POST like we sometimes do.
> > >>> In any way, when a 3.6.3 bug is merged in 3.6.3 it should be move=
d to
> > >>> MODIFIED, not a second before
> > >>>
> > >>>
> > >>> On Thu, Jan 28, 2016 at 12:23 PM, Yedidyah Bar David <
> didi(a)redhat.com>
> > >>> wrote:
> > >>>
> > >>>> On Thu, Jan 28, 2016 at 10:59 AM, Eyal Edri
<eedri(a)redhat.com>
> wrote:
> > >>>> >
> > >>>> >
> > >>>> > On Thu, Jan 28, 2016 at 10:23 AM, Yedidyah Bar David
<
> didi(a)redhat.com
> > >>>> >
> > >>>> > wrote:
> > >>>> >>
> > >>>> >> On Thu, Jan 28, 2016 at 10:08 AM, Eyal Edri
<eedri(a)redhat.com>
> > >>>> wrote:
> > >>>> >> > Maybe we should change the logic on moving bugs
to MODIFIED,
> > >>>> >> > Now that we moved to the version branch.
> > >>>> >> >
> > >>>> >> > Tal - any thoughts on a logic that SHOULD move
bugs to MODI=
FIED
> > >>>> that
> > >>>> >> > we'll
> > >>>> >> > be sure its OK?
> > >>>> >>
> > >>>> >> Repeating myself from a previous discussion: I think
we should
> never
> > >>>> move
> > >>>> >> bugs from POST to MODIFIED. Only a developer can know
if it's
> indeed
> > >>>> >> ready,
> > >>>> >> or another patch is still needed but was not yet
pushed. I th=
ink
> it's
> > >>>> >> safer
> > >>>> >> to miss bugs left on POST although they could have
been moved=
to
> > >>>> MODIFIED,
> > >>>> >> than the opposite - move to MODIFIED bugs that
actually requi=
re
> more
> > >>>> work.
> > >>>> >>
> > >>>> >
> > >>>> > You're optimistic that bugs will not stay on POST,
we've done =
it
> in
> > >>>> the
> > >>>> > past.
> > >>>> > This has a bigger risk of bugs getting left behind on
POST and
> > >>>> increasing
> > >>>> > the amount of
> > >>>> > bugs that are not verified on time.
> > >>>> >
> > >>>> > Its the easiest solution to drop this bot, but i belive
it wil=
l do
> > >>>> more
> > >>>> > damage than good.
> > >>>>
> > >>>> Perhaps, then, run it once a day and move to MODIFIED only if
la=
st
> patch
> > >>>> was merged at least X hours ago? Hopefully developers will not
w=
ait
> more
> > >>>> than X before pushing an additional patch for the same bug if
> needed.
> > >>>>
> > >>>> Of course, we then also have to fix the issue starting
current
> thread.
> > >>>>
> > >>>> >
> > >>>> >>
> > >>>> >> >
> > >>>> >> > e.
> > >>>> >> >
> > >>>> >> > On Thu, Jan 28, 2016 at 10:03 AM, Tal Nisan
<tnisan(a)redhat.=
com
> >
> > >>>> wrote:
> > >>>> >> >>
> > >>>> >> >> After merging a patch for a 3.6.3 bug on the
ovirt-engine-=
3.6
> > >>>> branch
> > >>>> >> >> the
> > >>>> >> >> bug is moved to MODIFIED, since the 3.6.3
branch was opened
> > >>>> yesterday
> > >>>> >> >> the
> > >>>> >> >> bug should stay in POST until merged in
ovirt-engine-3.6.3
> branch
> > >>>> as
> > >>>> >> >> well
> > >>>> >> >>
> > >>>> >> >>
> > >>>> >> >>
_______________________________________________
> > >>>> >> >> Infra mailing list
> > >>>> >> >> Infra(a)ovirt.org
> > >>>> >> >>
http://lists.ovirt.org/mailman/listinfo/infra
> > >>>> >> >>
> > >>>> >> >
> > >>>> >> >
> > >>>> >> >
> > >>>> >> > --
> > >>>> >> > Eyal Edri
> > >>>> >> > Associate Manager
> > >>>> >> > EMEA ENG Virtualization R&D
> > >>>> >> > Red Hat Israel
> > >>>> >> >
> > >>>> >> > phone: +972-9-7692018
> > >>>> >> > irc: eedri (on #tlv #rhev-dev #rhev-integ)
> > >>>> >> >
> > >>>> >> > _______________________________________________
> > >>>> >> > Infra mailing list
> > >>>> >> > Infra(a)ovirt.org
> > >>>> >> > http://lists.ovirt.org/mailman/listinfo/infra
> > >>>> >> >
> > >>>> >>
> > >>>> >>
> > >>>> >>
> > >>>> >> --
> > >>>> >> Didi
> > >>>> >
> > >>>> >
> > >>>> >
> > >>>> >
> > >>>> > --
> > >>>> > Eyal Edri
> > >>>> > Associate Manager
> > >>>> > EMEA ENG Virtualization R&D
> > >>>> > Red Hat Israel
> > >>>> >
> > >>>> > phone: +972-9-7692018
> > >>>> > irc: eedri (on #tlv #rhev-dev #rhev-integ)
> > >>>>
> > >>>>
> > >>>>
> > >>>> --
> > >>>> Didi
> > >>>>
> > >>>
> > >>>
> > >>
> > >>
> > >> --
> > >> Eyal Edri
> > >> Associate Manager
> > >> EMEA ENG Virtualization R&D
> > >> Red Hat Israel
> > >>
> > >> phone: +972-9-7692018
> > >> irc: eedri (on #tlv #rhev-dev #rhev-integ)
> > >>
> > >
> > >
> >
> >
> > --
> > Eyal Edri
> > Associate Manager
> > EMEA ENG Virtualization R&D
> > Red Hat Israel
> >
> > phone: +972-9-7692018
> > irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
> --
> David Caro
>
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>
> Tel.: +420 532 294 605
> Email: dcaro(a)redhat.com
> IRC: dcaro|dcaroest@{freenode|oftc|redhat}
> Web: www.redhat.com
> RHT Global #: 82-62605
>
=20
=20
=20
--=20
Eyal Edri
Associate Manager
EMEA ENG Virtualization R&D
Red Hat Israel
=20
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
IRC: dcaro|dcaroest@{freenode|oftc|redhat}
Web: www.redhat.com
RHT Global #: 82-62605
--s/l3CgOIzMHHjg/5
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJWscVEAAoJEEBxx+HSYmnDlakH+wZxi63IMTlCNuYnFt3llGgM
oZtJQvrQnD4ceBgCOtNeiATqBp0LY7+LAQZIg5NGiHRLKDTcFwJaS6In5zk5BkUO
fC8vBvyxuY6POuehG9Rm6fJrKmY1rBWDakbkf8Gihh9ISfzpmXHBXY3FX4I8xE4K
X6VJhbboZrirJB70a8EOFkQdWpWBKgSgBHAHjtEVCDyqrstAU4OZ2QlQ87O8FGg/
CnNooE8Z3kt9V+8pUsRmWk8o9uM7oDC6LUh4/2BmL+gUewwLS+u5lCuGAO6PQ0sI
4NWbyEGIOR7UJATV9rPczeG1yqFqpxCg9EYvWWYzzcGswqMotg1A65qg5lQDCWM=
=hPdC
-----END PGP SIGNATURE-----
--s/l3CgOIzMHHjg/5--