1:55 a.m.
On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this
header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
-
https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
-
https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
infra: looking at above commit messages, can we get automatically added the
following lines?
Reviewed-on: https://gerrit.ovirt.org/46540
on patch creation
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
on patch comment
Thanks,
Nir
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
6:51 a.m.
New subject: [ovirt-devel] Reported-By - giving credit to our testers
--ALfTUftag+2gvp1h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 11/13 08:55, Sandro Bonazzola wrote:
On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer
<nsoffer(a)redhat.com> wrote:
=20
> Hi all,
>
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
>
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this
> header.
>
> Here are some examples how we can use it:
>
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d929=
59ebbd
c7b598
=20
=20
infra: looking at above commit messages, can we get automatically added t=
he
following lines?
=20
Reviewed-on: https://gerrit.ovirt.org/46540
on patch creation
=20
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
on patch comment
There's no easy way to plug in extra stuff, that is done on vdsm by gerrit
itself because the project is set to 'cherry-pick', but that has consequenc=
es,
for starters, when you submit a patch, the commit that gets in is not the s=
ame
that you where reviewing (as the commit message changed) and thus you will =
be
forced to rebase all the patches that depended on it.
There's no built-in way either to change the commit on push (when
updating/creating the patch) without creating a new patch. That means that =
to
have that added, each time you send a patch a new one will be created, and =
each
time you add a comment for the first time to the patch, another patch will =
be
created too. Forcing the devel to refetch the commit each time he/she pushe=
s.
Not sure that smoothes up the dev process...
I think that the less painful path will be to use a commit hook locally, so=
the
commit message is changed locally first, but that will require the dev to
install it (we can ease that with a script or similar though)
=20
=20
=20
>
>
> Thanks,
> Nir
> _______________________________________________
> Devel mailing list
> Devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
=20
=20
=20
--=20
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--ALfTUftag+2gvp1h
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJWSyLmAAoJEEBxx+HSYmnD+E0H/ja833aqLEKyMrq0dsKyhQ1e
bBrnatZ6Jf6uBBCFJ9KU/Zc/TBXVvZ8D0Jk+28MQTt5SBHZ05aYjYikzEkPgNYCV
fcQQqtoiPkF8iF5nnZeLV3G/jdiBD7q/GNBSmNvKKgqDMUBDBnuIwTM9BUhO19dj
rqHOuupjkGWnPGeJFHkRqrqooDFAFJTKFPJPDfTVilJuL5w7iNJMnT8ns1mvUL2d
VzZW3ItbeqMxoScG8OcYMVbHD3Frld1XFADt52UP2F5nzW3lnYjpj9iA6JZLWNje
cjMgjHJzckp79UiDWuxqTpKs8metClXKf9N7sjuCcUD0E/VpBSqZfIvuz485b2k=
=GdED
-----END PGP SIGNATURE-----
--ALfTUftag+2gvp1h--
3323
days inactive
3327
days old
1 comments
2 participants
participants (2)
-
David Caro -
Sandro Bonazzola