New workflow flag on gerrit jenkins project
--g3RkK9jYN81zD2N+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! As a test to improve the review process I've enabled a new flag on the jenk= ins repo, the workflow flag. This flag has three values: 0 Work in progress (default) +1 Ready for review +2 Ready for merge The idea is to work on a patch without bothering anyone and when ready, explicitly ask for review in gerrit, that way the reviewer can easily differenciate between ready and not ready patches. Once the reviews have be= en done and all, the maintainer can set the +2 and merge the patch (the idea i= s in the near future use that flag to trigger zuul, so replacing the submit butt= on). The new flag shows nicely in the changes screen, making in really easy to s= ee which patches require reviews. Let's play on that project only for now and see if it works out. Thanks!! --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --g3RkK9jYN81zD2N+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVLpJRAAoJEEBxx+HSYmnDoEsH/jyUT1Odj400rvIAkvPMq1CA kg02W+UanDXxEhHNZUKdkmc9CheLiLm/aiC6+RROJQK5CFR15XFhate8M8WTwheA NRHXDdr7FdSMkql2Y3fZnBFZy2tCEaUG+0AEtYnVOhkPoXauYA0/YIXjbzo6BF8B QjMYkjDi5L4SLqod1Hf+bVhPk7fyv86xuo6l90saQnunf9A8gXeOoL5I+/1VjyvM v9IpZ0rGgr/g+ZTMnQbHVpz87nqdQKG0BR5fsZIF+I6k9UwMc4f+AIQ4n3m65MMk jkI5vLN3DP65DNrgKJZWOQvcM/bj1H740VSgPzt9ogVokbA/k4nVEvc07tP8a9A= =KBRu -----END PGP SIGNATURE----- --g3RkK9jYN81zD2N+--
------=_Part_588529_1154570296.1429119343334 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit +1. Excellent. Will it be possible to tell gerrit trigger plugin to run jobs only on patches with this flag? If not, might worth sending a patch to support it. It might reduce dramatically the amount of jobs running on patches. Sent from Nine From: David Caro Sent: Apr 15, 2015 7:31 PM To: infra@ovirt.org Subject: New workflow flag on gerrit jenkins project Hi! As a test to improve the review process I've enabled a new flag on the jenkins repo, the workflow flag. This flag has three values: 0 Work in progress (default) +1 Ready for review +2 Ready for merge The idea is to work on a patch without bothering anyone and when ready, explicitly ask for review in gerrit, that way the reviewer can easily differenciate between ready and not ready patches. Once the reviews have been done and all, the maintainer can set the +2 and merge the patch (the idea is in the near future use that flag to trigger zuul, so replacing the submit button). The new flag shows nicely in the changes screen, making in really easy to see which patches require reviews. Let's play on that project only for now and see if it works out. Thanks!! -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ------=_Part_588529_1154570296.1429119343334 Content-Type: multipart/related; boundary="----=_Part_588530_200730580.1429119343334" ------=_Part_588530_200730580.1429119343334 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable <html><body><div><div style=3D"font-family:Calibri, Arial, Helvetica, sans-= serif; font-size:12pt; color:#1F497D"><div>+1. Excellent.</div><div>Will it= be possible to tell gerrit trigger plugin to run jobs only on patches with= this flag?</div><div><br></div><div>If not, might worth sending a patch to= support it. It might reduce dramatically the amount of jobs running on pat= ches.</div> <div><br></div> <div id=3D"signature-x" style=3D"-webkit-user-select:none; font-family:Cali= bri, Arial, Helvetica, sans-serif; font-size:12pt; color:#1F497D">Sent from= <a href=3D"http://www.9folders.com/" style=3D"text-decoration:none;color:#= 009BDF">Nine</a></div></div><div id=3D"quoted_header" style=3D"clear:both;"=
<br/><div style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0p= t 0cm 0cm 0cm"><span style=3D"font-size:11.0pt;font-family:'Calibri','sans-= serif'"><b>From:</b> David Caro<br><b>Sent:</b> Apr 15, 2015 7:31 PM<br><b>= To:</b> infra@ovirt.org<br><b>Subject:</b> New workflow flag on gerrit jenk= ins project<br></span></div></div><br type=3D'attribution'></div><br><div> <br>Hi! <br> <br> <br>As a test to improve the review process I've enabled a new flag on the = jenkins <br>repo, the workflow flag. <br> <br>This flag has three values: <br> 0 Work in progress (default) <br> +1 Ready for review <br> +2 Ready for merge <br> <br>The idea is to work on a patch without bothering anyone and when ready, <br>explicitly ask for review in gerrit, that way the reviewer can easily <br>differenciate between ready and not ready patches. Once the reviews hav= e been <br>done and all, the maintainer can set the +2 and merge the patch (the id= ea is in <br>the near future use that flag to trigger zuul, so replacing the submit = button). <br> <br>The new flag shows nicely in the changes screen, making in really easy = to see <br>which patches require reviews. <br> <br>Let's play on that project only for now and see if it works out. <br> <br> <br>Thanks!! <br> <br> <br>--=20 <br>David Caro <br> <br>Red Hat S.L. <br>Continuous Integration Engineer - EMEA ENG Virtualization R&D <br> <br>Tel.: +420 532 294 605 <br>Email: dcaro@redhat.com <br>Web: <a href=3D"www.redhat.com">www.redhat.com</a> <br>RHT Global #: 82-62605 <br></div></body></html> ------=_Part_588530_200730580.1429119343334 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="g3RkK9jYN81zD2N+" Content-Disposition: inline
--g3RkK9jYN81zD2N+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! As a test to improve the review process I've enabled a new flag on the jenk= ins repo, the workflow flag. This flag has three values: 0 Work in progress (default) +1 Ready for review +2 Ready for merge The idea is to work on a patch without bothering anyone and when ready, explicitly ask for review in gerrit, that way the reviewer can easily differenciate between ready and not ready patches. Once the reviews have be= en done and all, the maintainer can set the +2 and merge the patch (the idea i= s in the near future use that flag to trigger zuul, so replacing the submit butt= on). The new flag shows nicely in the changes screen, making in really easy to s= ee which patches require reviews. Let's play on that project only for now and see if it works out. Thanks!! --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --g3RkK9jYN81zD2N+ Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVLpJRAAoJEEBxx+HSYmnDoEsH/jyUT1Odj400rvIAkvPMq1CA kg02W+UanDXxEhHNZUKdkmc9CheLiLm/aiC6+RROJQK5CFR15XFhate8M8WTwheA NRHXDdr7FdSMkql2Y3fZnBFZy2tCEaUG+0AEtYnVOhkPoXauYA0/YIXjbzo6BF8B QjMYkjDi5L4SLqod1Hf+bVhPk7fyv86xuo6l90saQnunf9A8gXeOoL5I+/1VjyvM v9IpZ0rGgr/g+ZTMnQbHVpz87nqdQKG0BR5fsZIF+I6k9UwMc4f+AIQ4n3m65MMk jkI5vLN3DP65DNrgKJZWOQvcM/bj1H740VSgPzt9ogVokbA/k4nVEvc07tP8a9A= =KBRu -----END PGP SIGNATURE----- --g3RkK9jYN81zD2N+-- ------=_Part_588530_200730580.1429119343334 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! As a test to improve the review process I've enabled a new flag on the jenk= ins repo, the workflow flag. This flag has three values: 0 Work in progress (default) +1 Ready for review +2 Ready for merge The idea is to work on a patch without bothering anyone and when ready, explicitly ask for review in gerrit, that way the reviewer can easily differenciate between ready and not ready patches. Once the reviews have be= en done and all, the maintainer can set the +2 and merge the patch (the idea i= s in the near future use that flag to trigger zuul, so replacing the submit butt= on). The new flag shows nicely in the changes screen, making in really easy to s= ee which patches require reviews. Let's play on that project only for now and see if it works out. Thanks!! --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ------=_Part_588530_200730580.1429119343334 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ------=_Part_588530_200730580.1429119343334-- ------=_Part_588529_1154570296.1429119343334--
--10jrOL3x2xqLmOsH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/15, Eyal Edri wrote:
+1. Excellent. Will it be possible to tell gerrit trigger plugin to run jobs only on pat= ches with this flag? =20 If not, might worth sending a patch to support it. It might reduce dramat= ically the amount of jobs running on patches.
Yes, the gerrit plugin does allow filtering by any custom flag (just checke= d)
=20 Sent from Nine =20 From: David Caro Sent: Apr 15, 2015 7:31 PM To: infra@ovirt.org Subject: New workflow flag on gerrit jenkins project =20 =20 Hi! =20 =20 As a test to improve the review process I've enabled a new flag on the je= nkins repo, the workflow flag. =20 This flag has three values: 0 Work in progress (default) +1 Ready for review +2 Ready for merge =20 The idea is to work on a patch without bothering anyone and when ready, explicitly ask for review in gerrit, that way the reviewer can easily differenciate between ready and not ready patches. Once the reviews have = been done and all, the maintainer can set the +2 and merge the patch (the idea= is in the near future use that flag to trigger zuul, so replacing the submit bu= tton). =20 The new flag shows nicely in the changes screen, making in really easy to= see which patches require reviews. =20 Let's play on that project only for now and see if it works out. =20 =20 Thanks!! =20 =20 --=20 David Caro =20 Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D =20 Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --10jrOL3x2xqLmOsH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVMAwbAAoJEEBxx+HSYmnDAUsH/0jSqfnZuzIXoqWkRMRIPyMt hs+a0rV1Q8PregEmWF4076ddsuWLNUn3lyaNbtu3YDJqRu5GPenCQsoJzk8dEtSB +Xlqy64IptCMHn4rk0F6h7XK6WOlP8njsE3SqmfeNKrSbOST+wa+EdE54hABTeqX AwKP6wh8SXrCxv94SnJBdpwzWVCEiUQsuzn0AlV5kKJdEXIhHRCZJQa+I3ts7uZ9 mcZgu/WDA6+vA37SBFH0/A2n+b0KE1boBSmd3ETBlgHAm/MN2+92g4OPV0DkfPyZ opWNztDCsQOBIhrMPR1O591nwqAd8GGedP6FI5Ee19D9dy77uvo8Yg+BIJOPr8M= =diCB -----END PGP SIGNATURE----- --10jrOL3x2xqLmOsH--
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: infra@ovirt.org Sent: Thursday, 16 April, 2015 10:23:08 PM Subject: Re: New workflow flag on gerrit jenkins project
On 04/15, Eyal Edri wrote:
+1. Excellent. Will it be possible to tell gerrit trigger plugin to run jobs only on patches with this flag?
If not, might worth sending a patch to support it. It might reduce dramatically the amount of jobs running on patches.
Yes, the gerrit plugin does allow filtering by any custom flag (just checked)
can you open a trac ticket on it so we'll implement it?
Sent from Nine
From: David Caro Sent: Apr 15, 2015 7:31 PM To: infra@ovirt.org Subject: New workflow flag on gerrit jenkins project
Hi!
As a test to improve the review process I've enabled a new flag on the jenkins repo, the workflow flag.
This flag has three values: 0 Work in progress (default) +1 Ready for review +2 Ready for merge
The idea is to work on a patch without bothering anyone and when ready, explicitly ask for review in gerrit, that way the reviewer can easily differenciate between ready and not ready patches. Once the reviews have been done and all, the maintainer can set the +2 and merge the patch (the idea is in the near future use that flag to trigger zuul, so replacing the submit button).
The new flag shows nicely in the changes screen, making in really easy to see which patches require reviews.
Let's play on that project only for now and see if it works out.
Thanks!!
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
participants (2)
-
David Caro -
Eyal Edri