I caught it on my check patch, when I updated the template file.
I need to verify, why in this case it didn't
On Sun, Jun 21, 2020 at 11:25 AM Yedidyah Bar David <didi(a)redhat.com> wrote:
On Sun, Jun 21, 2020 at 11:23 AM Galit Rosenthal
> This is the fix: https://gerrit.ovirt.org/#/c/109785/
> I've already saw the issue.
Can you please check why it was not caught on check-patch? Thanks.
> On Sun, Jun 21, 2020 at 10:54 AM Yedidyah Bar David <didi(a)redhat.com>
>> On Sun, Jun 21, 2020 at 6:18 AM <jenkins(a)jenkins.phx.ovirt.org> wrote:
>> > Project:
>> > Build:
>> This, and other HE suites in recent days, failed with:
>> Traceback (most recent call last):
>> File "/usr/lib64/python2.7/unittest/case.py", line 369, in run
>> File "/usr/lib/python2.7/site-packages/nose/loader.py", line 418,
>> addr.filename, addr.module)
>> File "/usr/lib/python2.7/site-packages/nose/importer.py", line 47,
>> in importFromPath
>> return self.importFromDir(dir_path, fqname)
>> File "/usr/lib/python2.7/site-packages/nose/importer.py", line 94,
>> in importFromDir
>> mod = load_module(part_fqname, fh, filename, desc)
>> line 35, in <module>
>> import test_utils
>> line 30, in <module>
>> from ost_utils.memoized import memoized
>> ImportError: No module named ost_utils.memoized
>> I assume that this is a result of:
>> and of the fact that some suites (HE, not sure about others) are still
>> using nose.
>> Marcin, can you please have a look? Thanks.
>> Galit, can you please check why check-patch on above patch didn't
>> fail? If it's because we removed HE suites from check-patch, because
>> they were unstable, then IMO we should add them back. They are rather
>> stable now, and if they fail, we should fix them. Thanks.
>> Best regards,
> GALIT ROSENTHAL
> SOFTWARE ENGINEER
> Red Hat
> galit(a)redhat.com T: 972-9-7692230