Re: [Engine-devel] checkstyle and tools project
Can we add a gerrit hook to run checkstyle on the code? rather than waiting it to be merged and fail on jenkins? ----- Original Message -----
From: "Laszlo Hornyak" <lhornyak@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Monday, June 24, 2013 11:15:38 AM Subject: [Engine-devel] checkstyle and tools project
Hi,
Checkstyle is not executed on tools project. I have sent a patch to gerrit to fix this, could you guys review?
And there are some more cleanup patches for tools: http://gerrit.ovirt.org/15720 http://gerrit.ovirt.org/15721 http://gerrit.ovirt.org/15722
Thank you, Laszlo _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Hi Eyal, Without the patch checkstyle will fail, there are some violations. But Yair ACKed the patchset, I will rebase and check it over again and merge, should be ready ~today~. ----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Laszlo Hornyak" <lhornyak@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, "infra" <infra@ovirt.org> Sent: Monday, June 24, 2013 4:28:44 PM Subject: Re: [Engine-devel] checkstyle and tools project
Can we add a gerrit hook to run checkstyle on the code? rather than waiting it to be merged and fail on jenkins?
----- Original Message -----
From: "Laszlo Hornyak" <lhornyak@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Monday, June 24, 2013 11:15:38 AM Subject: [Engine-devel] checkstyle and tools project
Hi,
Checkstyle is not executed on tools project. I have sent a patch to gerrit to fix this, could you guys review?
And there are some more cleanup patches for tools: http://gerrit.ovirt.org/15720 http://gerrit.ovirt.org/15721 http://gerrit.ovirt.org/15722
Thank you, Laszlo _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 06/24/2013 05:28 PM, Eyal Edri wrote:
Can we add a gerrit hook to run checkstyle on the code?
i wouldn't want gerrit to build, but can we add this to jenkins job?
rather than waiting it to be merged and fail on jenkins?
----- Original Message -----
From: "Laszlo Hornyak" <lhornyak@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Monday, June 24, 2013 11:15:38 AM Subject: [Engine-devel] checkstyle and tools project
Hi,
Checkstyle is not executed on tools project. I have sent a patch to gerrit to fix this, could you guys review?
And there are some more cleanup patches for tools: http://gerrit.ovirt.org/15720 http://gerrit.ovirt.org/15721 http://gerrit.ovirt.org/15722
Thank you, Laszlo _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
i believe it's running by default every time you run mvn compile (or install), so actually findbugs job will catch checkstyle errors too. (i.e fail to compile) ----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: "Laszlo Hornyak" <lhornyak@redhat.com>, "engine-devel" <engine-devel@ovirt.org>, "infra" <infra@ovirt.org> Sent: Monday, June 24, 2013 9:57:02 PM Subject: Re: [Engine-devel] checkstyle and tools project
On 06/24/2013 05:28 PM, Eyal Edri wrote:
Can we add a gerrit hook to run checkstyle on the code?
i wouldn't want gerrit to build, but can we add this to jenkins job?
rather than waiting it to be merged and fail on jenkins?
----- Original Message -----
From: "Laszlo Hornyak" <lhornyak@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Monday, June 24, 2013 11:15:38 AM Subject: [Engine-devel] checkstyle and tools project
Hi,
Checkstyle is not executed on tools project. I have sent a patch to gerrit to fix this, could you guys review?
And there are some more cleanup patches for tools: http://gerrit.ovirt.org/15720 http://gerrit.ovirt.org/15721 http://gerrit.ovirt.org/15722
Thank you, Laszlo _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
checkstyle runs as part of a compile phase in mvn. as long as you build your code before submitting it to gerrit you should be scott-free. ----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Laszlo Hornyak" <lhornyak@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, "infra" <infra@ovirt.org> Sent: Monday, June 24, 2013 5:28:44 PM Subject: Re: [Engine-devel] checkstyle and tools project
Can we add a gerrit hook to run checkstyle on the code? rather than waiting it to be merged and fail on jenkins?
----- Original Message -----
From: "Laszlo Hornyak" <lhornyak@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Monday, June 24, 2013 11:15:38 AM Subject: [Engine-devel] checkstyle and tools project
Hi,
Checkstyle is not executed on tools project. I have sent a patch to gerrit to fix this, could you guys review?
And there are some more cleanup patches for tools: http://gerrit.ovirt.org/15720 http://gerrit.ovirt.org/15721 http://gerrit.ovirt.org/15722
Thank you, Laszlo _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (4)
-
Allon Mureinik -
Eyal Edri -
Itamar Heim -
Laszlo Hornyak