Re: [Kimchi-devel] [PATCH v2 0/2] Keep UI Consistent in Guest Edit Window

On 06/06/2014 03:49 AM, Hongliang Wang wrote: > Make guest cdrom edit UI consistent with guest interface edit UI. The key point > is to edit cdrom properties in place. Because there is only one property can be > updated for a cdrom, it works fine this way. Though another inconsistence comes > up that in the same storage tab, there is also lines for disks, which have more > editable properties and it's not that easy to make all of these properties stay > in one line. So for disks, possibly we still need provide another window to let > users update properties. > So here are 2 choices: > C1) Apply this PATCH v2 to keep cdrom consistent with interface > C2) Apply PATCH v1 to keep cdrom consistent with disk > > Both are OK for me. > > v1 -> v2: > 2a) Made updating cdrom properties in place > (Aline's comment) > > Hongliang Wang (2): > Adjust Guest Edit Storage Tab Styles > Remove Unused Files > > ui/css/theme-default/guest-cdrom-edit.css | 57 ------------ > ui/css/theme-default/guest-edit.css | 99 +++++++------------- > ui/images/theme-default/guest-icon-sprite.png | Bin 6748 -> 0 bytes > ui/js/src/kimchi.guest_cdrom_edit_main.js | 85 ------------------ > ui/js/src/kimchi.guest_edit_main.js | 125 +++++++++++++++++++++----- > ui/pages/guest-cdrom-edit.html.tmpl | 70 --------------- > ui/pages/guest-edit.html.tmpl | 57 +++++++----- > 7 files changed, 166 insertions(+), 327 deletions(-) > delete mode 100644 ui/css/theme-default/guest-cdrom-edit.css > delete mode 100644 ui/images/theme-default/guest-icon-sprite.png > delete mode 100644 ui/js/src/kimchi.guest_cdrom_edit_main.js > delete mode 100644 ui/pages/guest-cdrom-edit.html.tmpl > We also need to keep consistence in the "+" button. In the network tab, it adds a new line to the list and user change the values accordingly. And in the storage tab, a new dialog is displayed to collect user input. Could you send a separate patch for that?